Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It doesn't handle nested SVGs #244

Closed
ststeiger opened this issue Jul 8, 2016 · 0 comments · Fixed by #293
Closed

It doesn't handle nested SVGs #244

ststeiger opened this issue Jul 8, 2016 · 0 comments · Fixed by #293

Comments

@ststeiger
Copy link

ststeiger commented Jul 8, 2016 •
edited

It doesn't handle nested SVGs.
Simple Example:

<svg xmlns="http://www.w3.org/2000/svg"
  xmlns:xlink="http://www.w3.org/1999/xlink">
  <svg x="10">
    <rect x="10" y="10" height="100" width="100"
        style="stroke:#ff0000; fill: #0000ff"/>
  </svg>
  <svg x="200">
    <rect x="10" y="10" height="100" width="100"
        style="stroke:#009900; fill: #00cc00"/>
  </svg>
</svg>
@mrbean-bremen mrbean-bremen mentioned this issue Mar 10, 2017
Merged
mrbean-bremen added a commit to mrbean-bremen/SVG that referenced this issue Mar 10, 2017
@mrbean-bremen
Correctly handle embedded SVG fragments without viewbox
52b7d32 
- calculate svg element bounds considering child svg fragments
- consider svg fragment offset in bounds / dimensions
- do not create view box if none is defined
- fixes svg-net#244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly handle embedded SVG fragments without viewbox mrbean-bremen/SVG
1 participant
@ststeiger