Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't render stroke of rect, if fill opacity is 0 #437

Closed
AnReZa opened this issue Apr 18, 2019 · 16 comments · Fixed by #439
Closed

Doesn't render stroke of rect, if fill opacity is 0 #437

AnReZa opened this issue Apr 18, 2019 · 16 comments · Fixed by #439
Labels

Comments

@AnReZa
Copy link

AnReZa commented Apr 18, 2019

I realized, that this SVG lib doesn't render the border of rectangles, when the fill opacity is set to 0:

<rect id="SvgjsRect1008" width="313" height="448" stroke-opacity="1" stroke="#ff0d28" stroke-width="3" fill-opacity="1" fill="rgba(0, 0, 0, 0)" x="360" y="48" />

This example will render the stroke in the same opacity as the fill color. So it's not rendered at all in this example. This, as far as I know, doesn't correspond to the SVG standard.

@mrbean-bremen
Copy link
Member

This is actually a regression I introduced myself in this commit. Should work in 2.4.1...

@mrbean-bremen
Copy link
Member

As far as I can see, this will be fixed by #433.

H1Gdev added a commit to H1Gdev/SVG that referenced this issue Apr 19, 2019
mrbean-bremen added a commit that referenced this issue Apr 19, 2019
- added failing test images for issue #437
H1Gdev added a commit to H1Gdev/SVG that referenced this issue Apr 23, 2019
@AnReZa
Copy link
Author

AnReZa commented Apr 23, 2019

It's nice to hear, that a fix is already available. Will there be an official release soon?

H1Gdev added a commit to H1Gdev/SVG that referenced this issue Apr 23, 2019
H1Gdev added a commit to H1Gdev/SVG that referenced this issue Apr 23, 2019
@NMGo
Copy link

NMGo commented Apr 23, 2019

I'm also seeing an issue with "fill-opacity", although I'm not sure if this is the same problem as reported here.
The svg markup is as follows:

<?xml version="1.0" encoding="UTF-8"?>
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" width="225" height="200">
  <g id="Layer 1">
    <path d="M150 0 L75 200 L225 200 z" fill-opacity="0" stroke="red" stroke-width="1" />
  </g>
</svg>

Expected rendering:
triangle_fill-opacity_expected

Result using 6ca4100 and H1Gdev's 8fa0c66:
triangle_fill-opacity_result

@AnReZa
Copy link
Author

AnReZa commented Apr 24, 2019

Can you please provide a quick hotfix release with the lastest changes and bugfixes for this issue?

H1Gdev added a commit to H1Gdev/SVG that referenced this issue Apr 24, 2019
H1Gdev added a commit to H1Gdev/SVG that referenced this issue Apr 24, 2019
H1Gdev added a commit to H1Gdev/SVG that referenced this issue Apr 24, 2019
H1Gdev added a commit to H1Gdev/SVG that referenced this issue Apr 24, 2019
@NMGo
Copy link

NMGo commented Apr 24, 2019

As per my comment in #439, the issue I reported above appears to be fixed as of H1Gdev's commit 7f392c3 (branch "opacity").

Thank you, @H1Gdev and @mrbean-bremen, for your assistance.

mrbean-bremen pushed a commit that referenced this issue Apr 24, 2019
)

- fixes first part of #437 - 'Doesn't render stroke of rect, if fill opacity is 0'
- added test images
mrbean-bremen pushed a commit that referenced this issue Apr 24, 2019
- small refactor in SvgColourServer
- fixes #437, second part - Apply 'fill-opacity' if not set 'fill'
- added test images
@mrbean-bremen
Copy link
Member

@H1Gdev - are you done fixing, or do you want to add more PRs?

@tebjan: provided @H1Gdev is done - he did a good job fixing these opacity issues, which partly have been regressions. Maybe it makes sense to make another minor release (as asked by @AnReZa)?

@H1Gdev
Copy link
Contributor

H1Gdev commented Apr 24, 2019

@mrbean-bremen

Yes.fix all my PRs.

@AnReZa
Copy link
Author

AnReZa commented May 7, 2019

@mrbean-bremen @tebjan Any chance to get a minor release for this fix? I would be really thankful! :)

@tebjan
Copy link
Contributor

tebjan commented May 7, 2019

yes, sounds good! will make a new release.

@tebjan
Copy link
Contributor

tebjan commented May 7, 2019

done, thanks for the fixes @H1Gdev and @mrbean-bremen!

@AnReZa
Copy link
Author

AnReZa commented May 7, 2019

@tebjan I cannot find it in the release list yet. Will it take some time? https://github.com/vvvv/SVG/releases

@tebjan
Copy link
Contributor

tebjan commented May 7, 2019

takes usually 30 minutes to be listed on nuget org. https://www.nuget.org/packages/Svg/2.4.3

@AnReZa
Copy link
Author

AnReZa commented May 7, 2019

Thank you!

@NMGo
Copy link

NMGo commented May 13, 2019

takes usually 30 minutes to be listed on nuget org. https://www.nuget.org/packages/Svg/2.4.3

There is no reference to #437 on the release notes for 2.4.3.

Thank you for making this happen.

@mrbean-bremen
Copy link
Member

Looks like the release notes on the nuget page belong to 2.4.2 - you can check the release notes in the Wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants