New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't render stroke of rect, if fill opacity is 0 #437
Comments
This is actually a regression I introduced myself in this commit. Should work in 2.4.1... |
As far as I can see, this will be fixed by #433. |
- added failing test images for issue #437
It's nice to hear, that a fix is already available. Will there be an official release soon? |
… issue. - Add test images.
I'm also seeing an issue with "fill-opacity", although I'm not sure if this is the same problem as reported here. <?xml version="1.0" encoding="UTF-8"?>
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" width="225" height="200">
<g id="Layer 1">
<path d="M150 0 L75 200 L225 200 z" fill-opacity="0" stroke="red" stroke-width="1" />
</g>
</svg> |
Can you please provide a quick hotfix release with the lastest changes and bugfixes for this issue? |
… issue. - Add test images.
… issue. - Add test images.
As per my comment in #439, the issue I reported above appears to be fixed as of H1Gdev's commit 7f392c3 (branch "opacity"). Thank you, @H1Gdev and @mrbean-bremen, for your assistance. |
- small refactor in SvgColourServer - fixes #437, second part - Apply 'fill-opacity' if not set 'fill' - added test images
Yes.fix all my PRs. |
@mrbean-bremen @tebjan Any chance to get a minor release for this fix? I would be really thankful! :) |
yes, sounds good! will make a new release. |
done, thanks for the fixes @H1Gdev and @mrbean-bremen! |
@tebjan I cannot find it in the release list yet. Will it take some time? https://github.com/vvvv/SVG/releases |
takes usually 30 minutes to be listed on nuget org. https://www.nuget.org/packages/Svg/2.4.3 |
Thank you! |
There is no reference to #437 on the release notes for 2.4.3. Thank you for making this happen. |
Looks like the release notes on the nuget page belong to 2.4.2 - you can check the release notes in the Wiki. |
I realized, that this SVG lib doesn't render the border of rectangles, when the fill opacity is set to 0:
This example will render the stroke in the same opacity as the fill color. So it's not rendered at all in this example. This, as far as I know, doesn't correspond to the SVG standard.
The text was updated successfully, but these errors were encountered: