Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bounds for SvgPath don't take transforms into account #830

Closed
birneamstiel opened this issue Feb 18, 2021 · 1 comment · Fixed by #915
Closed

Bounds for SvgPath don't take transforms into account #830

birneamstiel opened this issue Feb 18, 2021 · 1 comment · Fixed by #915
Labels
bug

Comments

@birneamstiel
Copy link

Description

PR #282 (Issue #281) introduced the logic for applying transforms to SvgPathBasedElements. Since SvgPath overrides the Bounds getter and simply returns this.Path(null).GetBounds() it bypasses possible transforms. Is this intended?
If it is not I would propose simply removing the getter for SvgPath and fall back to the SvgPathBasedElement 's one. I could create a PR accordingly...
@birneamstiel birneamstiel changed the title Bounds for SvgPath does't take transforms into account Bounds for SvgPath don't take transforms into account Feb 19, 2021
@mrbean-bremen
Copy link
Member

Sorry for the long delay...
I don't think this was intended (I made that PR, but I don't actually remember it...), so please go ahead and make a PR if you are still willing!

H1Gdev added a commit to H1Gdev/SVG that referenced this issue Oct 17, 2021
@H1Gdev
Fix: svg-net#830 'Bounds for SvgPath don't take transforms into accou…
56544e1 
…nt' issue.
@H1Gdev H1Gdev mentioned this issue Oct 17, 2021
Merged
mrbean-bremen pushed a commit that referenced this issue Oct 17, 2021
@H1Gdev
Make sure that SvgPath takes transforms into account (#915)
f778899 
* Add test.
* Fixes #830 'Bounds for SvgPath don't take transforms into account' issue
* Update ReleaseNotes.md.
github-actions bot pushed a commit that referenced this issue Oct 17, 2021
Make sure that SvgPath takes transforms into account (#915) BuildProc…
746a52f 
…essTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Tests doc docfx.json index.md license.txt Add test. BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Tests doc docfx.json index.md license.txt Fixes #830 'Bounds for SvgPath don't take transforms into account' issue
 BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Tests doc docfx.json index.md license.txt Update ReleaseNotes.md.
@RolandJosuran RolandJosuran mentioned this issue Oct 29, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: #830 'Bounds for SvgPath don't take transforms into account' issue. H1Gdev/SVG
2 participants
@mrbean-bremen @birneamstiel