Update ExCSS to 4.2.2. #1091
Merged
Update ExCSS to 4.2.2. #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Corresponds to TylerBrinks/ExCSS#152.
|
Update ExCSS to latest without impacting users. |
|
@inforithmics - please have a look |
inforithmics
approved these changes
Sep 8, 2023
| @@ -186,7 +186,7 @@ private void SetAttributes(SvgElement element, XmlReader reader, SvgDocument doc | |||
| var inlineSheet = stylesheetParser.Parse("#a{" + reader.Value + "}"); | |||
| foreach (var rule in inlineSheet.StyleRules) | |||
| foreach (var declaration in rule.Style) | |||
| element.AddStyle(declaration.Name, declaration.Value, SvgElement.StyleSpecificity_InlineStyle); | |||
| element.AddStyle(declaration.Name, declaration.Original, SvgElement.StyleSpecificity_InlineStyle); | |||
There was a problem hiding this comment.
Yes this is the solution, so that the values don't change. Because before the update .Value was the same as .Original
This was referenced Sep 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
What does this implement/fix? Explain your changes.
Any other comments?