Fix non-unique font names #453
Conversation
- support v3.5, v4.0, v4.5.2, v4.7.2 and dotnetcore2.2 - added support for Appveyor build - added explict FrameworkPathOverride to projects - added <IsTextProject> to csproj file - remove net35 from unittests. Updated licence method.
- removed / replaced EXCLUDE defines - added back System.Web - added back projects for SVG viewer and test runner - added back AssemblyInfo, no not generate it in .NETCore - removed FrameworkPathOverride - seems not to work correctly with current version - removed unneeded framework versions
…e the DPI. Possible fix for svg-net#427 Also: * add a barebones unit test for this * note that even the Windows code isn't correct as soon as you have multiple screens * on macOS, causes 20 instead of 5 unit tests to pass
- don't use Win32-specific interop calls to determine the DPI if not on Windows - possible fix for svg-net#427 - add a barebones unit test for this - note that even the Windows code isn't correct as soon as you have multiple screens - on macOS, causes 20 instead of 5 unit tests to pass
* 'netcore' of github.com:chucker/SVG: Don't use Windows-specific calls if not on Windows
|
Hmmm, maybe I should have made the pull request to |
| @@ -56,7 +56,7 @@ protected override void Render(ISvgRenderer renderer) | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Gets the <see cref="GraphicsPath"/> for this element. | |||
| /// Gets the <see cref="System.Drawing.Drawing2D.GraphicsPath"/> for this element. | |||
There was a problem hiding this comment.
Is this change unnecessary ?
There was a problem hiding this comment.
Thanks for that - but can you please make a PR from current master? E.g. in case you haven't cloned the original branch, something like:
git remote add vvvv https://github.com/vvvv/SVG
git fetch --all
git branch -b vvvv_master -t vvvv/master
git co vvvv_master
git co -b font-names-pr
... add your changes
git commit -a
git push --set-upstream origin font-names-pr
Otherwise it is difficult to review and to merge...
Thanks!
Note: you may already know all of this, this is just in case; and this is out of my head, so no guarantee it is all correct
|
(Will do when I get around to it; maybe this weekend) |
|
Sure, thanks! |
|
@chucker - if you don't mind, I will just incorporate your fix manually to have it in for the next release, as it is actually a small change. |
|
Sure, that’s fine! |
|
Thanks! |
See #452.
This is only a workaround. However, given that
FindFontcompares by name, we probably need to do something like this. (We might be able to better filter/order which fonts are "valid" or most likely to be the one referenced in the SVG?)