Fix: xlink:href value format. #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for another fix! I will have a closer look tonight, but I noticed that there are 2 open issues releated to different aspects of xlink:href: #71 and #220. Both have some code attached, which is related to the same location. If you get the time - could you please look if it makes sense to integrate these?
|
Sorry, no - I guess we can just adapt an existing SVG to use these constructs. |
H1Gdev
added a commit
to H1Gdev/SVG
that referenced
this pull request
Aug 27, 2019
H1Gdev
added a commit
to H1Gdev/SVG
that referenced
this pull request
Aug 28, 2019
- It doesn't work properly with certain IRIs, so fix it in another way. - ref. svg-net#455.
H1Gdev
added a commit
to H1Gdev/SVG
that referenced
this pull request
Sep 2, 2019
- It doesn't work properly with certain IRIs, so fix it in another way. - ref. svg-net#455.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format of xlink:href value is invalid.
So, output SVG file is not rendered on browsers.
For example, part of
pservers-grad-01-b.svgSVG file output.