Added support for the SvgScript tag #558
Conversation
Base creation of the script tag (type placeholder)
Added testing for the attributes
Updated test suite
…t's fall back to the IsNullOrEmpty
| [SvgAttribute("type")] | ||
| public string ScriptType | ||
| { | ||
| get { return _scriptType; } |
There was a problem hiding this comment.
If there is no special reason, set it to Attributes like any other element.
There was a problem hiding this comment.
Refactored this. I think I used a wrong example to base this code on. Reworked this to use the attribute collection, this also removed the need to manually output the attributes.
| return true; | ||
| } | ||
|
|
||
| protected override void WriteAttributes(System.Xml.XmlTextWriter writer) |
There was a problem hiding this comment.
Do you need to override WriteAttributes ?
There was a problem hiding this comment.
The code did not correctly output the attributes in the previous setup, so yeah at that moment I did. However using the attributes collection makes this code no longer necessary.
System.XML is now a using instead of a fully qualified class lateron
… attribute writer and local fields
|
@H1Gdev good remarks, I mad the changes you suggested. Many of the changes were due to me using an incorrect (or outdated) element to base my code on. |
There was a problem hiding this comment.
@gvheertum - Thanks a lot, this looks like a helpful extension!
@H1Gdev - thanks for the review! Please check if all findings are addressed - I'll merge after your approval.
As I already wrote, I won't have much free time in the next weeks, so I appreciate someone else reviewing PRs 👍
Reference Issue
Should address #167 which requests the addition of script tags.
What does this implement/fix? Explain your changes.
Allows the creation of SvgScript in the SVG document and can parse the script tags in a SVG file in a type-safe way. Adding of SvgScript was already possible in the past by using a generic tag, having a typed tag for scripts will make handling scripts easier.
Included test cases to test behavior of the script tag on reading and outputting.