Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #632 'Does not render .svg properly' issue. #639

Merged
merged 3 commits into from
Jan 12, 2020
Merged

Fix: #632 'Does not render .svg properly' issue. #639

merged 3 commits into from
Jan 12, 2020

Conversation

H1Gdev
Copy link
Contributor

@H1Gdev H1Gdev commented Jan 12, 2020 •
edited

Reference Issue

Fixes #632.

What does this implement/fix? Explain your changes.

Use terms that can be parsed from beginning.

Any other comments?

Fixes in ExCSS.

mrbean-bremen
mrbean-bremen approved these changes Jan 12, 2020
View reviewed changes
Copy link
Member

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That is more straightforward than I thought, thanks!

@mrbean-bremen
Copy link
Member

Ah, and as always, could you add an entry in the release notes (something like "Added handling of invalid property in parser")?

@mrbean-bremen
Copy link
Member

Thanks!

@mrbean-bremen mrbean-bremen merged commit f3991b4 into svg-net:master Jan 12, 2020
@H1Gdev H1Gdev deleted the issues branch January 12, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbean-bremen mrbean-bremen mrbean-bremen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not render .svg properly
2 participants
@H1Gdev @mrbean-bremen