New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoordinateParser should handle NumState.invalid first #640
CoordinateParser should handle NumState.invalid first #640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Can you add a release note entry for the fix? Also, a test would be nice (e.g. test image + PNG).
@H1Gdev - can you have a second look, please?
Added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add review comment.
Fixed review comments |
Thanks! |
* Fixed regression introduce by #640 * Added tests
* Fixed regression introduce by svg-net#640 * Added tests
Reference Issue
e-polyline-004.svg
e-polygon-004.svg
What does this implement/fix? Explain your changes.
Any other comments?