Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #707 'Problems with entities/styles' issue. #713

Merged
merged 1 commit into from Apr 20, 2020
Merged

Fix: #707 'Problems with entities/styles' issue. #713

merged 1 commit into from Apr 20, 2020

Conversation

H1Gdev
Copy link
Contributor

@H1Gdev H1Gdev commented Apr 17, 2020 •
edited

Reference Issue

Fixes #707

Ref. #90

What does this implement/fix? Explain your changes.

Any other comments?

@H1Gdev
Copy link
Contributor Author

H1Gdev commented Apr 17, 2020 •
edited

I fixed these issues(#707, #651), but I think that SvgNodeReader and SvgTextReader should be obsoleted.

These inherited classes have side effects and cause issues like this one.

These classes are needed for SvgDocument class Open method with entities.
But I don't think it's necessary because # 651 didn't work until it was resolved, and Open(XmlDocument document, , Dictionary<string, string> entities) doesn't exist.

@mrbean-bremen mrbean-bremen merged commit 328cc8b into svg-net:master Apr 20, 2020
@H1Gdev H1Gdev deleted the issues branch April 21, 2020 00:02
@H1Gdev H1Gdev mentioned this pull request Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with entities/styles
2 participants
@H1Gdev @mrbean-bremen