Parse significant whitespace #745
Conversation
Source/SvgDocument.cs
Outdated
| @@ -1,4 +1,4 @@ | |||
| using System; | |||
| using System; | |||
There was a problem hiding this comment.
It seems that the file encoding has changed.
Please apply setting of EditorConfig.
There was a problem hiding this comment.
According to VS code, the file is encoded in UTF-8 with BOM and CRLF, as is specified in .editorconfig. Also, I compared the previous and new version of this file with a HEX editor and the first couple of rows are identical. To be honest, I have no idea why GitHub highlights the first line as a change.
There was a problem hiding this comment.
BOM does not exist in this source file.
There was a problem hiding this comment.
It should now be present
|
Please add tests like this PR. |
Sure |
Sure, done! |
doc/ReleaseNotes.md
Outdated
| @@ -8,6 +8,7 @@ The release versions are NuGet releases. | |||
| * check if BaseUri is absolute (see [PR #738](https://github.com/vvvv/SVG/pull/738)) | |||
|
|
|||
| ### Fixes | |||
| * fixed the parsing of significant whitespace (see [#744](https://github.com/vvvv/SVG/issues/744) and [PR #744])(https://github.com/vvvv/SVG/pull/745)) | |||
There was a problem hiding this comment.
And remove close bracket.
[PR #745](
There was a problem hiding this comment.
Fixed it - apologies for my sloppiness
doc/ReleaseNotes.md
Outdated
| @@ -8,6 +8,7 @@ The release versions are NuGet releases. | |||
| * check if BaseUri is absolute (see [PR #738](https://github.com/vvvv/SVG/pull/738)) | |||
|
|
|||
| ### Fixes | |||
| * fixed the parsing of significant whitespace (see [#744](https://github.com/vvvv/SVG/issues/744) and [PR #745](https://github.com/vvvv/SVG/pull/745)) | |||
There was a problem hiding this comment.
By convention, the list seems to be in ascending order.
Please add it below the list.
Reference Issue
Fixes #744
What does this implement/fix? Explain your changes.
It configures the XmlTextReader to parse significant whitespace. For reference: XmlTextReader.WhitespaceHandling Property
Note:
Any other comments?
I really don't know too much about either SVG or XML, so I hope this fix is appropriate.