Fix ArgumentException in SvgTextBase.Bounds when has a whitespace line #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 24, 2022 16:59
Fix ArgumentException in SvgTextBase.Bounds when has tspan.text is only whitespace
add testsuite
added 2 commits
March 24, 2022 17:16
correct indentation
change test file to plain svg
There was a problem hiding this comment.
Looks good! Can you please add your test file to PassingTests.csv (for the unit tests) and PassingTests.txt (for the test runner), and also add an entry to the release notes?
|
This process does not work with SVG file for this test. |
H1Gdev
reviewed
Mar 25, 2022
H1Gdev
reviewed
Mar 25, 2022
|
@mrbean-bremen Sorry, I don't know which release version I shoud update this pull request issue to. |
H1Gdev
reviewed
Mar 25, 2022
Ah, we just had a release - just put it on top of that, you may prepend Unreleased as a header. |
mrbean-bremen
approved these changes
Mar 25, 2022
H1Gdev
reviewed
Mar 25, 2022
H1Gdev
reviewed
Mar 27, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Mar 27, 2022
…ace (#963) BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Tests doc docfx.json index.md license.txt Update SvgTextBase.Drawing.cs BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Tests doc docfx.json index.md license.txt add test and release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ArgumentException in SvgTextBase.Bounds when a svgtext has a textspan having only whitespace.
Reference Issue
What does this implement/fix? Explain your changes.
Any other comments?