Enforce linting #261
Merged
Enforce linting #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkphl
added a commit
that referenced
this pull request
Mar 17, 2018
|
@TheDancingCode Thanks! I agree that ESLint would be the better choice nowadays (and I'm using ESLint in other projects). However, I'm planning a complete rewrite of svg-sprite and I probably wouldn't switch prior to that (I'm utterly lacking the time for this all, though ...) |
|
Alright. Good luck with the rewrite. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JSHint errors that went uncaught. Adds linting as a
pretesttask, to avoid further errors.I recommend switching from JSHint to ESLint and its
eslint:recommendedrules.