New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prettier to xo config and switch to two-space indentation #611
Conversation
So, here we have 2 choices:
In the first case, not sure what the gain is, though. Just being able to format other files except for js/ts etc? I don't mind going with the second way, as long as we agree on a common set of options. |
@XhmikosR let's go with second variant. Then step by step, file by file we will include prettier to all code base. |
@XhmikosR should we land it? And by the way, I think we should change |
Please hold on to this. I haven't had a chance to look at it yet. |
f5d6cca
to
29545ce
Compare
@@ -3,17 +3,18 @@ | |||
'use strict'; | |||
|
|||
/** | |||
* svg-sprite is a Node.js module for creating SVG sprites | |||
* Svg-sprite is a Node.js module for creating SVG sprites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way we don't touch the license headers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, https://github.com/hosseinmd/prettier-plugin-jsdoc/#Options
jsdocCapitalizeDescription: false
So far I see the following:
Overall, I don't mind proceeding with this as long as we sort the above :) |
@XhmikosR this is a big list. I think in this case we should not use prettier. Otherwise we would struggle to fight against it. Prettier is a zero-config like solution, if there are so much factors with it's integration, then we can say it just does not fit here |
Closing for now. I landed the 2-space indentation in #812 |
@XhmikosR for me, conversations in commits are quite inconvenient. Let's communicate here.
Have you seen this changes? Do you agree/disagree with them?
Sorry in advance for this PR.