Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix incorrect type annotation #743

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

strager
Copy link
Contributor

@strager strager commented Oct 26, 2022

SVGSpriter.prototype.add is called with Buffer instances in some tests, and that seems to be intentionally supported. Fix the outdated JSDoc which says that only strings are allowed.

SVGSpriter.prototype.add is called with Buffer instances in some tests,
and that seems to be intentionally supported. Fix the outdated JSDoc
which says that only strings are allowed.
@XhmikosR XhmikosR requested a review from Kreeg October 26, 2022 13:28
Copy link
Member

@Kreeg Kreeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XhmikosR I think we should narrow down expected types, but for now it's OK.

@Kreeg Kreeg merged commit 3baa895 into svg-sprite:main Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants