Fix shape.id.separator regression
#745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…names in the relative path.
Set correct order for testing
Kreeg
reviewed
Oct 29, 2022
Kreeg
reviewed
Oct 29, 2022
Configure relative content from base and full paths, it's a calculated value.
Kreeg
approved these changes
Oct 31, 2022
|
I'll try to backport this and cut a patch release because on main we have dropped Node.js 12 support. |
XhmikosR
added a commit
that referenced
this pull request
Oct 31, 2022
* Fix: Keep using relative path to generate a valid ID with the folder names in the relative path. * Fix: Taking care if no base path is defined * Add test * Add test to validate the correct relative path. Set correct order for testing * Update shape.js * Remove test for relative content. Configure relative content from base and full paths, it's a calculated value. * Update shape.constructor.test.js Co-authored-by: XhmikosR <xhmikosr@gmail.com> Co-authored-by: Andrew <1666622+Kreeg@users.noreply.github.com>
XhmikosR
added a commit
that referenced
this pull request
Nov 8, 2022
XhmikosR
added a commit
that referenced
this pull request
Nov 12, 2022
XhmikosR
added a commit
that referenced
this pull request
Nov 12, 2022
XhmikosR
added a commit
that referenced
this pull request
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I created a fork to fix the problem reported here: #740
Regards
Fixes #740