Update devDependencies and fix new issues #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are not using modules, so we aren't in strict mode by default.
XhmikosR
commented
Apr 12, 2023
| @@ -7,7 +7,7 @@ const yaml = require('js-yaml'); | |||
| const SVGSpriterConfig = require('../../../lib/svg-sprite/config.js'); | |||
|
|
|||
| jest.mock('node:fs'); | |||
| jest.mock('yaml'); | |||
| jest.mock('js-yaml'); | |||
There was a problem hiding this comment.
I don't quite get how this worked all this time 😛
Kreeg
reviewed
Apr 12, 2023
| @@ -324,10 +324,7 @@ module.exports = class SVGSpriterConfig { | |||
| ['padding'].forEach(function(property) { | |||
| let spacing; | |||
|
|
|||
| if (!Array.isArray(this.spacing[property])) { | |||
There was a problem hiding this comment.
Yeah, I guess the no negated condition rule I guess added some fixes
|
Yes. The problem with playwright-chromium still exists. I do not have much time to deal with it and I sure this is a chromium problem rather than a playwright. |
Kreeg
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Kreeg: I haven't updated playwright-chromium due to that old issue you were facing. I assume you are still facing it with the latest version, right?
The only other deps that are outdated is glob and pngjs. For glob there's no hurry and in fact we better keep it to v7.x for now. pngjs I didn't try to update it, so if you have time feel free to update it :)