Jest: limit maxWorkers, maxConcurrency and use workerThreads #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
xmr/jest-config
branch
from
255e8cf
to
49e2aef
Compare
XhmikosR
force-pushed
the
xmr/jest-config
branch
from
25ad245
to
3c4d006
Compare
|
Maybe this should be an OS related config? Just thinking out loud |
|
Did you try the branch? If it's not significantly slower, I'd like to keep it simple. I don't see the point of spawning 600+ processes when running the tests, regardless of the OS. |
|
No I didn't. If it OK on your machine and CI - I'm OK with that. |
Kreeg
approved these changes
Apr 12, 2023
|
Could you give it a go on your machine too? I'd like to see how big is the slowdown there before we merge this. CI is the same, because it has 2 threads which is the minimum we set. |
|
@XhmikosR 34.548 s vs 30.104 s (config vs main). So it is OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time difference hit isn't that big. We might even want to go with
os.cpus() - 4oros.cpus() / 2.Now Jest doesn't spawn 600 processes on my Windows VM.
CI seems to be slower, though. We could use a different number of threads for CI.