Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate speed regression after 2.1.0 #1412

Closed
XhmikosR opened this issue Mar 9, 2021 · 1 comment
Closed

Investigate speed regression after 2.1.0 #1412

XhmikosR opened this issue Mar 9, 2021 · 1 comment
Labels

Comments

@XhmikosR
Copy link
Contributor

XhmikosR commented Mar 9, 2021

Initially noticed it on #954 (comment)

C:\Users\xmr\Desktop>curl https://upload.wikimedia.org/wikipedia/commons/archive/2/2e/20180507223736%21Germany_%28%2Bdistricts_%2Bmunicipalities%29_location_map_2013.svg>1.svg
C:\Users\xmr\Desktop>npm i svgo@2.1.0 -g
C:\Users\xmr\AppData\Roaming\npm\svgo -> C:\Users\xmr\AppData\Roaming\npm\node_modules\svgo\bin\svgo
+ svgo@2.1.0
added 1 package from 1 contributor and updated 1 package in 1.848s

C:\Users\xmr\Desktop>set NODE_OPTIONS=--max_old_space_size=8192 && svgo 1.svg -o 2.svg

1.svg:
Done in 164252 ms!
74491.22 KiB - 49.3% = 37749.765 KiB

C:\Users\xmr\Desktop>npm i svgo@latest -g
C:\Users\xmr\AppData\Roaming\npm\svgo -> C:\Users\xmr\AppData\Roaming\npm\node_modules\svgo\bin\svgo
+ svgo@2.2.2
removed 1 package and updated 1 package in 1.521s

C:\Users\xmr\Desktop>set NODE_OPTIONS=--max_old_space_size=8192 && svgo 1.svg -o 2.svg

1.svg:
Done in 355186 ms!
74491.22 KiB - 49.3% = 37737.378 KiB

https://github.com/svg/svgo/compare/v2.1.0...v2.2.2?w=1

So far I've noticed this:

Results may vary on other machines/OS'es

@XhmikosR XhmikosR added the bug label Mar 9, 2021
@XhmikosR XhmikosR changed the title Investigate speed after 2.1.0 Investigate speed regression after 2.1.0 Mar 9, 2021
@TrySound
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants