Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of flags from the lipis/flag-icon-css are broken after running it for the whole folder #162

Closed
lipis opened this issue Dec 23, 2013 · 13 comments
Labels

Comments

@lipis
Copy link

lipis commented Dec 23, 2013

So I was trying to normalise this collection of flags and by running the svgo on them got a few broken ones... https://github.com/lipis/flag-icon-css

Here are some obvious examples that you can simply verify (but more likely there are more errors):

https://github.com/lipis/flag-icon-css/blob/master/flags/4x3/cn.svg
https://github.com/lipis/flag-icon-css/blob/master/flags/4x3/gr.svg
https://github.com/lipis/flag-icon-css/blob/master/flags/4x3/cn.svg
https://github.com/lipis/flag-icon-css/blob/master/flags/4x3/bj.svg
https://github.com/lipis/flag-icon-css/blob/master/flags/4x3/uy.svg

Maybe the original ones are totally screwed but the svgo should be able to remove the crap without destroying the file.. :D

@tomByrer
Copy link

tomByrer commented Apr 7, 2014

I've noticed some other SVG files I d/l from Wikipedia are broken after the default SVGO conversion. IIRC I got a more usable result after turning off some of the optimizations.

@GreLI
Copy link
Member

GreLI commented Nov 2, 2014

Unfortunately, links are dead.

@lipis
Copy link
Author

lipis commented Nov 2, 2014

I'll update with the working one..

@lipis lipis changed the title Lots of flags from the koppi/iso-country-flags-svg-collection are broken after running it for the whole folder Lots of flags from the lipis/flag-icon-css are broken after running it for the whole folder Nov 2, 2014
@lipis
Copy link
Author

lipis commented Nov 2, 2014

@GreLI The original repo was deleted but the actual flags are in one of my repos now.. I updated the links

@GreLI GreLI closed this as completed in 17d29e9 Nov 4, 2014
@lipis
Copy link
Author

lipis commented Nov 4, 2014

So this is fixed?! Looking forward to test it... did you make a new release?!

@GreLI
Copy link
Member

GreLI commented Nov 4, 2014

Just made a release. Enjoy!

@lipis
Copy link
Author

lipis commented Nov 4, 2014

For most of the flags it worked perfectly.. for now I just found this:

Here is the original:
https://dl.dropboxusercontent.com/u/15234/va-orig.svg

and after pretty optimising it became like this:
https://dl.dropboxusercontent.com/u/15234/va.svg

@GreLI
Copy link
Member

GreLI commented Nov 4, 2014

Nothing is perfect. I'll look on this later.

@GreLI GreLI reopened this Nov 4, 2014
@lipis
Copy link
Author

lipis commented Nov 4, 2014

@lipis
Copy link
Author

lipis commented Nov 4, 2014

@GreLI sure man... and I really appreciate the responses.. just trying to help :) most of them are perfect... finally they will be optimised...!!!

@GreLI
Copy link
Member

GreLI commented Nov 4, 2014

Yes, thank you! It really helps to hunt bugs.

@flekschas
Copy link

Some minor issues are still present when optimizing flags py.svg and va.svg.

@GreLI
Copy link
Member

GreLI commented Apr 22, 2015

Probably, transforms precision issue. See #334.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants