-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of flags from the lipis/flag-icon-css are broken after running it for the whole folder #162
Comments
I've noticed some other SVG files I d/l from Wikipedia are broken after the default SVGO conversion. IIRC I got a more usable result after turning off some of the optimizations. |
Unfortunately, links are dead. |
I'll update with the working one.. |
@GreLI The original repo was deleted but the actual flags are in one of my repos now.. I updated the links |
So this is fixed?! Looking forward to test it... did you make a new release?! |
Just made a release. Enjoy! |
For most of the flags it worked perfectly.. for now I just found this: Here is the original: and after pretty optimising it became like this: |
Nothing is perfect. I'll look on this later. |
Also this one is breaking: |
@GreLI sure man... and I really appreciate the responses.. just trying to help :) most of them are perfect... finally they will be optimised...!!! |
Yes, thank you! It really helps to hunt bugs. |
Some minor issues are still present when optimizing flags |
Probably, transforms precision issue. See #334. |
So I was trying to normalise this collection of flags and by running the
svgo
on them got a few broken ones... https://github.com/lipis/flag-icon-cssHere are some obvious examples that you can simply verify (but more likely there are more errors):
https://github.com/lipis/flag-icon-css/blob/master/flags/4x3/cn.svg
https://github.com/lipis/flag-icon-css/blob/master/flags/4x3/gr.svg
https://github.com/lipis/flag-icon-css/blob/master/flags/4x3/cn.svg
https://github.com/lipis/flag-icon-css/blob/master/flags/4x3/bj.svg
https://github.com/lipis/flag-icon-css/blob/master/flags/4x3/uy.svg
Maybe the original ones are totally screwed but the
svgo
should be able to remove the crap without destroying the file.. :DThe text was updated successfully, but these errors were encountered: