fix(plugins): Cleanup ids when style/script tag is empty #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a empty style tag in the file, ids should be properly cleaned up.
cleanupIDs plugin is disabled when a script or style tag is present. I assume that this is because they might contain an id. If these tags are empty there is no point in not cleaning the id though. When running svgo with the option `multipass: true`, it allows us to first run `inlineStyles` plugin to empty the style tag. Then, we can run `cleanupIDs` plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanupIDsplugin is not run when a script or style tag is present. I assume that this is because they might contain an id.If the tags are empty we can clean these ids though.
When running svgo with the option
multipass: true, it allows us to first runinlineStylesplugin to empty the style tag. Then, we can runcleanupIDsplugin.In the new test, an example of this transformation!