chore: use external xast type declarations #1805
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes our custom type declarations for Xast in favor of the ones suggested by xast.
Motivation
While it makes sense to declare types of Xast for our plugin API, I think it'd be better to avoid maintaining them as part of this library/application if there are conventional solutions available already.
My hope was actually to explore some libraries surrounding Xast, in particular, xast-util-from-xml and xast-util-select. Unfortunately, neither of these meet fulfil our needs atm.
Not sure if this is a worthwhile change, so feedback welcome.