Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(removeHiddenElems): handle defs better #1879

Merged
merged 8 commits into from Dec 9, 2023
Merged

fix(removeHiddenElems): handle defs better #1879

merged 8 commits into from Dec 9, 2023

Commits on Dec 9, 2023

  1. fix(removeHiddenElems): handle defs better

    @KTibow
    KTibow committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    b179707 View commit details
    Browse the repository at this point in the history

  2. Fix all regression tests

    @KTibow
    KTibow committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    2ad4495 View commit details
    Browse the repository at this point in the history

  3. address review (cleanup code and look at all href)

    @KTibow
    KTibow committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    790767a View commit details
    Browse the repository at this point in the history

  4. add tests (untested)

    @KTibow
    KTibow committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    dcd805f View commit details
    Browse the repository at this point in the history

  5. Remove empty defs without multipass

    @KTibow
    KTibow committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    70a2d93 View commit details
    Browse the repository at this point in the history

  6. fix a typo in the test, track all defs like before

    @KTibow
    KTibow committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    9e508ae View commit details
    Browse the repository at this point in the history

  7. remove a out of scope change

    @KTibow
    KTibow committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    2b93feb View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Seth Falco <seth@falco.fun>
    @KTibow @SethFalco
    KTibow and SethFalco committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    4298044 View commit details
    Browse the repository at this point in the history