Allow config to specify use of self closing tags #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradbarrow
force-pushed
the
short-tag-config
branch
from
3820030
to
36d76ac
Compare
Allow config to specify `useShortTags` (default true). When `useShortTags` is true, empty elements are terminated with /> When `useShortTags` is false, empty elements are closed with a full closing tag e.g. </path>
bradbarrow
force-pushed
the
short-tag-config
branch
from
36d76ac
to
bd64cde
Compare
GreLI
added a commit
that referenced
this pull request
Jul 6, 2015
Allow config to specify use of self closing tags
|
Nice job! |
|
Thanks @GreLI - I noticed the build has broken on this change - I was intending to fix that error this morning. Is that something you can fix easily? |
|
No, it's my previos commit. Don't worry. |
|
FIxed it today. |
|
Hey @GreLI what's the plan looking like for this change? |
|
Ah, I see a release just recently! Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow config to specify
useShortTags(default true).When
useShortTagsis true, empty elements are terminated with />When
useShortTagsis false, empty elements are closed with a full closing tage.g. < / path >