Fix "Invalid character entity" with illustrator svgs #272 #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contribution! I was simultaneously thinking in the same direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes external entities declared in doctype known to the sax parser in svgo. This allows the source file to be saved in illustrator with preserved editing capabilities. Added a very basic test to check and sample file to check whether the parser runs through. Shouldn't have too many side effects.
Note: there are activities around entity parsing going on in the sax parser itself, see isaacs/sax-js#162. But it doesn't seem to have high priority. I think putting a (maybe temporary) fix in svgo is useful because the workflow Illustrator -> SVG -> SVGO -> Grunt Webfont is quite common.