Add plugin to cleanup XML namespaces #830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added plugin to cleanup (remove unused and minify used) XML namespaces. Replaced 'removeUnusedNS' plugin with new plugin ('cleanupNS'). Fixed bug in 'cleanupIDs' which would allow a generated minified ID to be the same as a preserved ID.
|
Closing as I don't think this should be part of SVGO as XML namespaces are not specific to SVG, and as the code in the commit is very unclean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added plugin to cleanup (remove unused and minify used) XML namespaces. Replaced removeUnusedNS plugin with new plugin (cleanupNS). Fixed bug in cleanupIDs which would allow a generated minified ID to be the same as a preserved ID. Close #844