now adds prefixes to each class individually #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzaidman
force-pushed
the
948-add-option-to-format-class-name
branch
from
c0875b6
to
1811be5
Compare
|
I think id should be a different case. |
vzaidman
force-pushed
the
948-add-option-to-format-class-name
branch
3 times, most recently
from
d0b749a
to
2b4d4ca
Compare
tremby
reviewed
Apr 24, 2018
plugins/prefixIds.js
Outdated
| node.name = addPrefix(node.name); | ||
| return; | ||
| } | ||
|
|
||
| // .class | ||
| if (node.type === 'ClassSelector' && node.name) { | ||
| node.name = node.name.split(' ').map(addPrefix).join(' '); |
There was a problem hiding this comment.
Might be better to split on /\s+/?
vzaidman
force-pushed
the
948-add-option-to-format-class-name
branch
5 times, most recently
from
1295c8c
to
0654fb5
Compare
vzaidman
force-pushed
the
948-add-option-to-format-class-name
branch
from
0654fb5
to
5d29b2e
Compare
|
ok i fixed the whole thing and added a complex test about it |
|
when will this be published? |
|
@GreLI, could you cut a release? It's been a couple of months since this was merged. |
|
SVGO v1.1.0 with the fix has been just released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.