Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create symbols & fallback for unexpected type #39

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

create symbols & fallback for unexpected type #39

wants to merge 3 commits into from

Conversation

ebalder
Copy link

@ebalder ebalder commented Feb 9, 2015

  • the 'symbol' case is pretty straightforward
  • I think that the 'unexpected type' case shouldn't stop building the tree, in this case, an inkscape-generated sodipodi:namedview element (which was the root of my svg) was irrelevant but stopping everything else from being imported.

@ebalder
create symbols & fallback for unexpected type
33635b4 
- the 'symbol' case is pretty straightforward
- I think that the 'unexpected type' case shouldn't be a reason to stop building the tree, in this case, an inkscape-generated <sodipodi:namedview> element (which was the root of my svg) was irrelevant but stopping everything from working.
@ebalder
fix symbol children not attached to the element
20d3ed5
@ebalder
minify
9dca457
@ebalder ebalder changed the title Lexas patch 1 create symbols & fallback for unexpected type Feb 9, 2015
@ebalder ebalder mentioned this pull request Feb 9, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ebalder