Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to aiclassify and aitemplates #150

Merged
merged 5 commits into from
May 18, 2024
Merged

Improvements to aiclassify and aitemplates #150

merged 5 commits into from
May 18, 2024

Conversation

svilupp
Copy link
Owner

@svilupp svilupp commented May 18, 2024

Added

  • Improved support for aiclassify with OpenAI models (you can now encode upto 40 choices).
  • Added a template for routing questions :QuestionRouter (to be used with aiclassify)

Changed

  • [BREAKING] Changed behaviour of aitemplates(name::Symbol) to look for the exact match on the template name, not just a partial match. This is a breaking change for the aitemplates function only. Motivation is that having multiple matches could have introduced subtle bugs when looking up valid placeholders for a template.

Fixed

  • Fixed a bug where aiclassify would not work when returning the full conversation for choices with extra descriptions

Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (15982fe) to head (7e09062).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   92.84%   92.84%   -0.01%     
==========================================
  Files          42       42              
  Lines        3229     3228       -1     
==========================================
- Hits         2998     2997       -1     
  Misses        231      231              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svilupp svilupp merged commit 6ae31a5 into main May 18, 2024
6 checks passed
@svilupp svilupp deleted the aitemplates-fix branch May 18, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant