Fix for IPRoute objects that can still be used after close in Python 2 #443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed IPRoute contexts could still be used after being closed in Python 2. I assume I'm not the first one to stumble upon this, but it has caused inconsistent behavior between Python versions in our codebase so I figured it warranted a fix.
The gist of the issue is that
NetlinkSocket
stores references to the underlying socket methods, which can change (and do). So instead of storing references I used__getattr__
to always return the "current" methods.The reference-based approach caused IPRoute sockets to be in an inconsistent state when closed:
Thus data still could be sent over the socket even if it was considered closed.
Only Python 2 is affected, because in Python 3 socket methods point to the "real thing" and are not replaced by dummies when closing.
I guess a
__getattr__
call could have a performance overhead compared to the old method, so tell me if this is a problem and I'll think of another way.Cheers,
Étienne