iproute: fix link_lookup when index/ifname is not set #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use set intersection to check if index nor ifname is in kwargs. And add a trivial test for this Bug-Url: svinota#724 Related-To: svinota#712
|
Confirmed that this fix resolves the issue we saw and reported in 724. |
|
Yeah, we really need this to unblock our gates. Hopefully this can be reviewed and merged soon! 👍 |
apevec
pushed a commit
to redhat-openstack/rdoinfo
that referenced
this pull request
Aug 16, 2020
0.5.13 update caused a regression which affected octavia jobs, to resolve include the patch[1] which is not merged yet, updated rdo-common fork with the patch[2]. Once fix is released in 0.5.14 patch can be cleaned up. [1] svinota/pyroute2#725 [2] rdo-common/python-pyroute2@98b74a1 Related-Bug: lp#1891293 Change-Id: Ic92e6e8badbdd22b004617b78b1ae95c96485db1
openstack-mirroring
pushed a commit
to openstack/requirements
that referenced
this pull request
Sep 10, 2020
Version 0.5.13 of pyroute2 had a regression[1] that broke Octavia, but it also contained a fix required for neutron. This patch bumps pyroute2 to 0.5.14 to fix the regression. [1] svinota/pyroute2#725 Change-Id: I1959152e35557e61857d5f3f6e6146e8abe11ea8
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Sep 10, 2020
* Update requirements from branch 'master'
- Merge "Bump pyroute2 upper constraint to 0.5.14"
- Bump pyroute2 upper constraint to 0.5.14
Version 0.5.13 of pyroute2 had a regression[1] that broke Octavia,
but it also contained a fix required for neutron.
This patch bumps pyroute2 to 0.5.14 to fix the regression.
[1] svinota/pyroute2#725
Change-Id: I1959152e35557e61857d5f3f6e6146e8abe11ea8
bmwiedemann
added a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Sep 16, 2020
https://build.opensuse.org/request/show/834879 by user dirkmueller + dimstar_suse - update to 0.5.14: * iproute: ip neigh get <svinota/pyroute2#723> * iproute: link_lookup fix <svinota/pyroute2#725> * nftables: missing hooks <svinota/pyroute2#732> * netns: fix <svinota/pyroute2#733>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use set intersection to check if index nor ifname is in kwargs. And add
a trivial test for this
Bug-Url: #724
Related-To: #712