Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why assume the patch have the same depth? #5

Open
ghost opened this issue Jan 10, 2021 · 6 comments
Open

Why assume the patch have the same depth? #5

ghost opened this issue Jan 10, 2021 · 6 comments

Comments

@ghost
Copy link

ghost commented Jan 10, 2021

It seems that the keypoints extracted by DSO mainly distribute around the edge of objects, thus the depth variance may be large, so I'm wondering if the same depth assumption is plausible, could you please share the idea of this implementation?

@niujinshuchong
Copy link
Contributor

@vvvsice Good question.

It's true that depths around the points are not same. The key idea is to compare patch similarity between different frames. You can also implement this idea in different manner. For example, first project 3D points to different frames and crop a patch around the projected coordinate then calculate the loss. However, this implementation ignore camera rotation while assuming same depth accounts for camera rotation.

@ghost
Copy link
Author

ghost commented Jan 13, 2021

I see, thanks a lot.

@ghost ghost closed this as completed Jan 13, 2021
@oxyhexagen
Copy link

@vvvsice Good question.

It's true that depths around the points are not same. The key idea is to compare patch similarity between different frames. You can also implement this idea in different manner. For example, first project 3D points to different frames and crop a patch around the projected coordinate then calculate the loss. However, this implementation ignore camera rotation while assuming same depth accounts for camera rotation.

Hi,thanks for sharing this excellent work.
Could you please explain "this implementation ignore camera rotation while assuming same depth accounts for camera rotation" in more detail? I'm still confused about this.
Much appreciate.

@niujinshuchong
Copy link
Contributor

@belkahorry For the first one, you always crop a local patch around the projected point. The patch is a regular grid and not dependent on the camera rotation. For the second one, we project a patch (instead of point) with same depth to the other image and the projected patch is not a regular grid anymore and thus depends on camera rotation.

@oxyhexagen
Copy link

It's clear,thanks!

@ShuweiShao
Copy link

Hi, I'm still a bit confused as to why the regular grid would have a connection to the camera rotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants