Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows support #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add windows support #17

wants to merge 1 commit into from

Conversation

us
Copy link

@us us commented Oct 2, 2019

Tested on windows 10.

@dakotahawkins
Copy link

Do you do anything special to install torch?

I get:

ERROR: Could not find a version that satisfies the requirement torch==1.2.0 (from -r requirements.txt (line 6)) (from versions: 0.1.2, 0.1.2.post1, 0.1.2.post2)
ERROR: No matching distribution found for torch==1.2.0 (from -r requirements.txt (line 6))

The last time this happened in another project I think I gave up :(

@piaozhx
Copy link
Member

piaozhx commented Oct 16, 2019

@dakotahawkins Installing Pytorch for windows by pip need special links, e.g.
image

You can find more information from pytorch official website

@dakotahawkins
Copy link

Yeah I tried that. Maybe now it's because I installed python 3.8, idk.

At any rate, for windows support I'd consider adding this step to some kind of script. I tried (everything short of downgrading python) but couldn't make it work.

@piaozhx
Copy link
Member

piaozhx commented Oct 16, 2019

@dakotahawkin, It seems that there are not offical support of python3.8 till now, you should use python3.7 or python3.6 etc as shown in above figure

@haviduck
Copy link

haviduck commented Oct 19, 2019

@dakotahawkins check in cmd where python, where pip, where pip3 and see if you dont have any wrong environmentals. i had 2.x hijacking my 3.7, had to remove the paths and then torch would install.

@haviduck
Copy link

@us is numpy.array.long() working for you?

@haviduck
Copy link

to get output video in win, change this line:
https://github.com/us/impersonator/blob/45fe9813d5d1c93cdf769d2cabca040c5ce72846/utils/video.py#L49
to :
os.system("ffmpeg -y -i %s -vcodec h264 %s" % (tmp_avi_video_path, output_mp4_path))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants