Ensure Redis clusters and multiplexed connections are supported #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-daniel
force-pushed
the
daniel/redis-cluster
branch
2 times, most recently
from
d9bdb85
to
988f91e
Compare
svix-james
reviewed
Jun 7, 2023
svix-daniel
force-pushed
the
daniel/redis-cluster
branch
2 times, most recently
from
988f91e
to
11e0fbf
Compare
svix-james
reviewed
Jun 7, 2023
svix-gabriel
previously approved these changes
Jun 9, 2023
svix-daniel
force-pushed
the
daniel/redis-cluster
branch
2 times, most recently
from
3b34bcf
to
0bd6170
Compare
svix-daniel
changed the title
svix-daniel
force-pushed
the
daniel/redis-cluster
branch
from
0bd6170
to
3157dcc
Compare
svix-james
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes ensure that clustered Redis is supported in addition to non-clustered Redis (using multiplexed connections). Note that these changes remove uses of the non-multiplexed connections. These changes also add the standard tests for both Redis and clustered Redis.