sqs: Allow specifying the AWS config explicitly #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be able to change associate types without breaking callers of those methods.
… by allowing to pass just a DSN. Also prepares for addition of extra SQS configuration fields.
… instead of loading it from the environment.
svix-jplatte
force-pushed
the
jplatte/sqs-init
branch
from
63e1444
to
c40b395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, omniqueue was always loading it from the environment, which doesn't work for all use cases.
This required a small hack (first and third commit) to minimize the likelihood of breaking users of the API, since I think we don't want to make a semver-incompatible release for this.
Closes private issue.