Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Queue Storage support #65

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Azure Queue Storage support #65

merged 5 commits into from
Apr 12, 2024

Conversation

jaymell
Copy link
Contributor

@jaymell jaymell commented Mar 28, 2024 •
edited
Loading

Note that the blocking receives are not possible in Azure
Queue Storage and as such, calling receive on an empty
queue will return immediately with QueueError::NoData.

@jaymell jaymell requested a review from a team as a code owner March 28, 2024 18:21
@jaymell jaymell force-pushed the james/aqs branch 2 times, most recently from f227b93 to fdcb6a7 Compare March 28, 2024 18:28
svix-jplatte
svix-jplatte reviewed Mar 28, 2024
View reviewed changes
omniqueue/src/backends/azure_queue_storage.rs Outdated Show resolved Hide resolved
omniqueue/src/backends/azure_queue_storage.rs Outdated Show resolved Hide resolved
omniqueue/Cargo.toml Outdated Show resolved Hide resolved
@jaymell jaymell force-pushed the james/aqs branch 2 times, most recently from bd28999 to 12f38cf Compare March 28, 2024 21:51
svix-jplatte
svix-jplatte previously approved these changes Apr 2, 2024
View reviewed changes
@jaymell jaymell marked this pull request as draft April 10, 2024 04:41
@jaymell jaymell force-pushed the james/aqs branch 4 times, most recently from 1177893 to 08a6d80 Compare April 10, 2024 20:15
@jaymell
Azure Queue Storage support
fc3fa1d
@jaymell
Add test for empty receive_all
3a81e22
@jaymell
Review comments
1964be8
@jaymell
Refactors
7a3de7b 
* Have client pass StorageCredentials object instead of access key;
  this should cover all potential ways of authenticating.
* Support configurabile visibility-timeout when messages received,
  else they will be immediately eligible for de-queueing.
@svix-james svix-james marked this pull request as ready for review April 10, 2024 21:27
@svix-james
Copy link

I went ahead and deferred making any dramatic changes for the builder here. I still have some questions about the proper way to do so. I feel like to have the most value, I would need to actually expose a builder for the config struct itself, which is more than I want to do at the moment.

svix-jplatte
svix-jplatte previously approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@svix-jplatte svix-jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor suggestions.

omniqueue/src/backends/azure_queue_storage.rs Outdated Show resolved Hide resolved
omniqueue/src/backends/azure_queue_storage.rs Outdated Show resolved Hide resolved
omniqueue/tests/it/azure_queue_storage.rs Show resolved Hide resolved
@svix-james svix-james merged commit b48d4ad into svix:main Apr 12, 2024
5 checks passed
@jaymell jaymell deleted the james/aqs branch April 12, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svix-jplatte svix-jplatte svix-jplatte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaymell @svix-james @svix-jplatte