Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqs: Error early when payload is too large #68

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

svix-jplatte
Copy link
Member

Would be nice to have a new QueueError variant for this, but that would be a breaking change since the enum is not #[non_exhaustive].

@svix-jplatte svix-jplatte requested a review from a team as a code owner April 4, 2024 10:27
Copy link
Contributor

@svix-gabriel svix-gabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add a new variant and bump the version?

@svix-jplatte
Copy link
Member Author

Would be nice if we could do at least one point release before breaking stuff again 😅

Then we should bump the version to 0.3.0 and release once we actually know what we want to have in that release.

@svix-jplatte
Copy link
Member Author

svix-jplatte commented Apr 4, 2024

… in particular how we're going to deal with #63. Though could also defer that.

Copy link
Contributor

@svix-gabriel svix-gabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would definitely prefer a new enum variant. I don't really mind bumping the version more frequently (especially for such a trivial "breaking change"), but I won't hold up this change.

@svix-jplatte
Copy link
Member Author

Let's discuss on Slack.

@svix-jplatte svix-jplatte merged commit 8543c69 into main Apr 4, 2024
4 checks passed
@svix-jplatte svix-jplatte deleted the jplatte/sqs-max-payload-size branch April 4, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants