Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Move all integration tests into one test binary #1214

Merged
merged 2 commits into from Feb 21, 2024

Conversation

svix-jplatte
Copy link
Member

I think this is the last repo where this wasn't done yet 馃

@svix-jplatte svix-jplatte requested a review from a team February 20, 2024 11:35
svix-gabriel
svix-gabriel previously approved these changes Feb 20, 2024
@svix-gabriel svix-gabriel dismissed their stale review February 20, 2024 14:03

I missed the failing CI

@svix-jplatte
Copy link
Member Author

Yeah, I wonder what could be wrong there...

- Fewer binaries to link for testing
- Allows running specific integration test suite, e.g. `cargo test sqs`
- Allows running more tests in parallel

See also:
https://matklad.github.io/2021/02/27/delete-cargo-integration-tests.html
@svix-jplatte svix-jplatte changed the title Move all integration tests into one test binary server: Move all integration tests into one test binary Feb 20, 2024
@svix-jplatte
Copy link
Member Author

Split off the CI and bridge changes into separate PRs (#1217, #1218), as bridge CI shouldn't block this improvement for the server component.

@svix-jplatte svix-jplatte merged commit 27cf863 into main Feb 21, 2024
3 checks passed
@svix-jplatte svix-jplatte deleted the jplatte/integration-tests branch February 21, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants