Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: Remove PooledConnectionLike in favor of upstream traits #1229

Merged
merged 3 commits into from Feb 22, 2024
Merged

server: Remove PooledConnectionLike in favor of upstream traits #1229

merged 3 commits into from Feb 22, 2024

Conversation

svix-jplatte
Copy link
Member

@svix-jplatte svix-jplatte commented Feb 22, 2024 •
edited

Motivation

Our own redis traits are a maintenance burden and not necessary.

Solution

Implement redis::aio::ConnectionLike, get redis::AsyncCommands impl for free ✨

@svix-jplatte svix-jplatte requested a review from a team as a code owner February 22, 2024 14:54
@svix-jplatte svix-jplatte merged commit 6f9541d into main Feb 22, 2024
3 checks passed
@svix-jplatte svix-jplatte deleted the jplatte/redis-connectionlike branch February 22, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svix-james svix-james svix-james approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svix-jplatte @svix-james