server: Reduce redundant test runs #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The redis tests are now run once for the redis backend, and once for the redis cluster backend in run-tests.sh. Previously, all six runs would execute these tests, most of the time with the redis backend. Since these tests are relatively low-level, they are not affected by other configuration changes. It really only makes sense to run e2e tests with all the different configuration combinations.
|
Also, any objections against disabling bash linting? Idk if it ever linted against something useful. Before the latest commit, it outputted a bunch of which is an "info" lint that I think should never cause CI to fail. |
Without this, `cargo check` on just `svix-server_derive` was failing.
svix-jplatte
force-pushed
the
jplatte/redis-tests
branch
from
97d83ca
to
f927e67
Compare
|
While CI performance has quite high variability, there is a sign here that this improved CI runtime quite noticably: Here's page 1 of the most recent successful runs:
|
svix-james
reviewed
Mar 11, 2024
svix-onelson
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redis tests are now run once for the redis backend, and once for the redis cluster backend in run-tests.sh. Previously, all six runs would execute these tests, most of the time with the redis backend. Since these tests are relatively low-level, they are not affected by other configuration changes. It really only makes sense to run e2e tests with all the different configuration combinations.
@svix-onelson you were previously not convinced about this approach of using
#[ignore]d tests plus extra--ignoredtest runs w.r.t. rabbitmq. How do you feel about it here given the diff?