move security error handling to use ctx macro #658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added a
ctx!
macro to help make handling and tracing internal server errors much more straightforward. This PR addsctx!
invocations insecurity.rs
to a couple of common errors that were being manually transformed.This also let us axe the
to_internal_server_error
function.to_internal_server_error
was logging errors, but this was redundant witherror::Error
's logging inerror.rs
(when it gets turned into a response for axum).Motivation
security.rs
security.rs
Solution
Traceable
for the *Rejection types to makectx!
work