Publicly reexport types in the api pkg in rust
#806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-gabriel
approved these changes
Feb 6, 2023
svix-andor
added a commit
that referenced
this pull request
Feb 6, 2023
Like what's fixed in #806, sometimes types are accidentally not publicly reexported in the `api` package. This changes the import/reexport statement to a glob so generated models are automatically reexported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main
apipackage has so far reexported the types used in the functions it wraps, with a few exceptions. This PR moves these types from the privateusestatement to the publicly reexporting one.Fixes #805