Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query parameter to list endpoints newest-to-oldest #815

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

svix-andor
Copy link
Contributor

The overall pagination is still done first-to-last, but within a page results are listed last-to-first.

Builds on top of #812

@svix-andor svix-andor force-pushed the andor/endpoint-list-newest-first branch from c12c03e to cb23b39 Compare February 7, 2023 14:30
@svix-andor svix-andor force-pushed the andor/endpoint-list-newest-first branch from cb23b39 to 3de37f6 Compare February 7, 2023 16:40
@svix-andor svix-andor force-pushed the andor/endpoint-list-newest-first branch 2 times, most recently from bd12141 to 2e27f89 Compare February 8, 2023 09:52
The overall pagination is still done first-to-last, but within a page
results are listed last-to-first.
@svix-andor svix-andor force-pushed the andor/endpoint-list-newest-first branch from 2e27f89 to f697ed7 Compare February 8, 2023 10:11
Copy link
Member

@tasn tasn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine. Just making sure: you have the tests to ensure this works + tests to verify you haven't broken the ordering for anything else?

@svix-andor
Copy link
Contributor Author

I believe so. The again-generic apply_pagination and listing_response is only used for Endpoint listing, the remainders still use the direction specific variant (which I intend to remove once all have bidirectional listing).

@svix-andor svix-andor merged commit 4ef5ea5 into main Feb 8, 2023
@svix-andor svix-andor deleted the andor/endpoint-list-newest-first branch February 8, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants