Update dev readme adding affs - need to add to generic #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
keneanung
requested changes
Nov 15, 2016
| @@ -97,7 +97,8 @@ This the order that things happen on the prompt function: | |||
| 1. add it in raw-svo.diag.lua and add a new diagnose trigger for it | |||
| 1. add gaining affliction raw-svo.simple.lua, and if there's any complicated logic around it, to raw-svo.main.lua. Add triggers receiving the affliction. | |||
| 1. add losing/curing affliction in raw-svo.main.lua and the appropriate triggers | |||
| 1. add in tree curing system (touchtree action in raw-svo.dict.lua and raw-svo.main.lua) | |||
| 1. add to tree curing system (touchtree action in raw-svo.dict.lua and raw-svo.main.lua) | |||
| 1. add to generic cures (passive cures or cures that happen in blackout) (generic_cures_data in raw-svo.main.lua) | |||
There was a problem hiding this comment.
shouldn't this be raw-svo.valid.main.lua?
There was a problem hiding this comment.
There are also other references to raw-svo.main.lua and at least raw-svo.simple.lua which should have "valid" in them.
|
Sure, fixed. |
keneanung
approved these changes
Nov 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.