Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priest Changes #410

Merged
merged 2 commits into from Jul 11, 2019
Merged

Priest Changes #410

merged 2 commits into from Jul 11, 2019

Conversation

QwindorRousseau
Copy link

Contains the updates for the changes to the Priest class
-Removal of Healing and addition of Zeal and its components

*Priest update
@QwindorRousseau QwindorRousseau requested a review from a team July 11, 2019 12:50
Copy link
Contributor

@DazedxJoker DazedxJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate functions are created here.

svo.checkaction(svo.dict.stolebalance.happened, true)
lifevision.add(actions.stolebalance_happened.p, nil, 'healing')
lifevision.add(actions.stolebalance_happened.p, nil, 'zeal')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First instance

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now

lifevision.add(actions.gotbalance_happened.p)
end
end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second instance, I believe this is the correct one

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now

@QwindorRousseau QwindorRousseau merged commit 1b0c863 into in-client-svof Jul 11, 2019
@QwindorRousseau QwindorRousseau deleted the Priest-update branch July 11, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants