GMCP resource tracking 2.0 #825
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on Kriex's PR with updated gmcp tracking for all classes, but retaining original variable locations due to issues
TheLastDarkthorne
changed the title
|
I use svo.stats and svo.me in a bunch of places, so let me know whenever this is ready for testing and happy to make sure everything is working! |
Deleted class balance functions and checks (as they are now tracked safely through gmcp), deleted triggers for class balances that are tracked through gmcp, added new vforce alias, fixed some gmcp balance functions
Lots of changes, mostly deleting/disabling triggers that are not needed because they are either defs/affs tracked by gmcp so triggers are not neccessary for them. Also while I was at it, I decided to fix some wrong things I have seen through the code in some affs and other things I was looking while cleaning things. Still not done, there is a lot of triggers to be reviewed and disabled or deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Kriex's PR #734 with updated gmcp tracking for all classes, but retaining original variable locations due to issues with that approach. Since he's been MIA I decided to create another PR based on his awesome additions!
Work in progress so this is not ready yet, but creating the PR so I don't lose my changes. There are things that need to be done like:
@classor whatever)This is a fairly large change so please if someone can look at it and see if it is all okay and/or is able to test through multiple classes I will be thankful.
PS: Apparently,
statsorsvo.statsis used for quantified stats (numbers, like sunlight, essence, devotion, etc) andmeorsvo.meis used for the rest of things so I tried to retain that convention. There should be probably a comment explaining this but I can place one later too.