Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMCP resource tracking 2.0 #825

Open
wants to merge 4 commits into
base: in-client-svof
Choose a base branch
from

Conversation

TheLastDarkthorne
Copy link
Contributor

@TheLastDarkthorne TheLastDarkthorne commented Apr 26, 2023

Based on Kriex's PR #734 with updated gmcp tracking for all classes, but retaining original variable locations due to issues with that approach. Since he's been MIA I decided to create another PR based on his awesome additions!

Work in progress so this is not ready yet, but creating the PR so I don't lose my changes. There are things that need to be done like:

  • Delete triggers that are being used to populate the resources
  • Add prompt tags to all other things (or consolidate them all into one tag e.g. @class or whatever)
  • Delete anything that is capturing the values through prompt flags if any
  • Test of course!

This is a fairly large change so please if someone can look at it and see if it is all okay and/or is able to test through multiple classes I will be thankful.

PS: Apparently, stats or svo.stats is used for quantified stats (numbers, like sunlight, essence, devotion, etc) and me or svo.me is used for the rest of things so I tried to retain that convention. There should be probably a comment explaining this but I can place one later too.

Based on Kriex's PR with updated gmcp tracking for all classes, but retaining original variable locations due to issues
@TheLastDarkthorne TheLastDarkthorne changed the title GMCP resource tracking starting commit GMCP resource tracking 2.0 Apr 26, 2023
@MediaResAchaea
Copy link

I use svo.stats and svo.me in a bunch of places, so let me know whenever this is ready for testing and happy to make sure everything is working!

Deleted class balance functions and checks (as they are now tracked safely through gmcp), deleted triggers for class balances that are tracked through gmcp, added new vforce alias, fixed some gmcp balance functions
Lots of changes, mostly deleting/disabling triggers that are not needed because they are either defs/affs tracked by gmcp so triggers are not neccessary for them. Also while I was at it, I decided to fix some wrong things I have seen through the code in some affs and other things I was looking while cleaning things. Still not done, there is a lot of triggers to be reviewed and disabled or deleted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants