chore: Added more tests

svrooij · Oct 29, 2020 · d8ee722 · d8ee722
1 parent feeca71
commit d8ee722
Show file tree

Hide file tree

Showing 4 changed files with 61 additions and 4 deletions.
diff --git a/src/helpers/tts-helper.ts b/src/helpers/tts-helper.ts
@@ -37,7 +37,7 @@ export default class TtsHelper {
     return data.cdnUri || data.uri;
   }
 
-  static async TtsOptionsToNotification(options: PlayTtsOptions): Promise<PlayNotificationOptions | undefined> {
+  static async TtsOptionsToNotification(options: PlayTtsOptions): Promise<PlayNotificationOptions> {
     const endpoint = options.endpoint ?? process.env.SONOS_TTS_ENDPOINT;
     if (endpoint === undefined) {
       throw new Error('TTS endpoint is required, check the documentation.');

diff --git a/src/sonos-device.ts b/src/sonos-device.ts
@@ -422,9 +422,6 @@ export default class SonosDevice extends SonosDeviceBase {
     this.debug('PlayTTS(%o)', options);
 
     const notificationOptions = await TtsHelper.TtsOptionsToNotification(options);
-    if (typeof (notificationOptions) === 'undefined') {
-      return false;
-    }
 
     return await this.PlayNotification(notificationOptions);
   }

diff --git a/tests/helpers/metadata-helper.test.ts b/tests/helpers/metadata-helper.test.ts
@@ -27,6 +27,12 @@ describe('MetadataHelper', () => {
       expect(track).to.be.an('object');
     });
 
+    it('Guess metadata for Spotify user playlist', () => {
+      const uri = 'spotify:user:37i9dQZF1DX4WYpdgoIcn6'
+      const track = MetadataHelper.GuessTrack(uri);
+      expect(track).to.be.an('object');
+    });
+
     it('Produces same metadata as legacy for Spotify track', () => {
       const track = MetadataHelper.GuessTrack(spotifyTrack);
       expect(track).to.be.an('object');
@@ -35,6 +41,12 @@ describe('MetadataHelper', () => {
       const metadata = MetadataHelper.TrackToMetaData(track);
       assert.equal(metadata, legacyMetadataObject.metadata);
     });
+
+    it('Returns undefined for unsupported uri', () => {
+      const uri = 'fake:music:service'
+      const track = MetadataHelper.GuessTrack(uri);
+      expect(track).to.be.undefined;
+    });
   });
 
   describe('GuessTrackAndMetadata', () => {
@@ -68,6 +80,39 @@ describe('MetadataHelper', () => {
     });
   })
 
+  describe('ParseDIDLTrack', () => {
+    it('parsed r:streamContent correctly 2', () => {
+      const artist = 'Guus Meeuwis';
+      const title = 'Brabant'
+      const id = 'FAKE_ITEM_ID'
+      const didl = {
+        _id: id,
+        'r:streamContent': `${artist} - ${title}`
+      }
+      const result = MetadataHelper.ParseDIDLTrack(didl, 'fake_host')
+      expect(result).to.be.an('object');
+      expect(result).to.have.nested.property('Artist', artist);
+      expect(result).to.have.nested.property('Title', title);
+      expect(result).to.have.nested.property('ItemId', id);
+    })
+
+    it('parsed r:streamContent and r:radioShowMd correctly', () => {
+      const artist = 'Guus Meeuwis';
+      const title = 'Brabant'
+      const id = 'FAKE_ITEM_ID'
+      const didl = {
+        _id: id,
+        'r:streamContent': artist,
+        'r:radioShowMd': title
+      }
+      const result = MetadataHelper.ParseDIDLTrack(didl, 'fake_host')
+      expect(result).to.be.an('object');
+      expect(result).to.have.nested.property('Artist', artist);
+      expect(result).to.have.nested.property('Title', title);
+      expect(result).to.have.nested.property('ItemId', id);
+    })
+  })
+
   describe('TrackToMetaData', () => {
     it('returns emtpy string when track undefined', () => {
       const result = MetadataHelper.TrackToMetaData(undefined);

diff --git a/tests/services/alarm-clock.service.test.ts b/tests/services/alarm-clock.service.test.ts
@@ -31,6 +31,21 @@ describe('AlarmClockService', () => {
     });
   });
 
+  describe('DestroyAlarm', () => {
+    it('sends the correct request', async () => {
+      TestHelpers.mockRequest('/AlarmClock/Control',
+        '"urn:schemas-upnp-org:service:AlarmClock:1#DestroyAlarm"',
+        '<u:DestroyAlarm xmlns:u="urn:schemas-upnp-org:service:AlarmClock:1"><ID>1</ID></u:DestroyAlarm>',
+        'DestroyAlarmResponse',
+        'AlarmClock');
+
+      const service = new AlarmClockService(TestHelpers.testHost, 1400);
+      const result = await service.DestroyAlarm({ ID: 1 });
+      expect(result).to.be.true;
+
+    })
+  })
+
   describe('GetTimeZone', () => {
     it('works', async () => {
       TestHelpers.mockRequest('/AlarmClock/Control',