Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong typed events #140

Merged
merged 4 commits into from Jul 22, 2021
Merged

Strong typed events #140

merged 4 commits into from Jul 22, 2021

Conversation

svrooij
Copy link
Owner

@svrooij svrooij commented Jul 22, 2021

Strong typed events

Description

Previously this library used a different StrongTyped events library, this PR tries to switch to another version.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1056542616

  • 13 of 19 (68.42%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 78.44%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sonos-device.ts 12 18 66.67%
Totals Coverage Status
Change from base Build 1002286232: -0.05%
Covered Lines: 1461
Relevant Lines: 1864

💛 - Coveralls

@svrooij svrooij merged commit a6346f2 into beta Jul 22, 2021
@svrooij svrooij deleted the feature/better-events branch July 22, 2021 14:46
@github-actions
Copy link

🎉 This PR is included in version 2.4.1-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants