Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some packages and apply needed compliance to xmlParser Changes #180

Closed
wants to merge 1 commit into from

Conversation

theimo1221
Copy link
Contributor

Your title here

Update to adress fast-xml security vulnerability

Description

This PR updates the package and contains needed changes to comply to new functionality of the library.

Your checklist for this pull request

馃毃 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • Check you add tests for added code.

馃挃 Thank you!

@svrooij
Copy link
Owner

svrooij commented Jun 11, 2023

  • Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.

鈽濓笍?

And are the License issues with the parser resolved?
A long time ago the author suddenly changed the license to be something proprietary, that made me pick the last version with the MIT license and never update.

After this PR, if you change it to the beta branch, I鈥檒l create a new none beta release with all the changes and this change.

@theimo1221
Copy link
Contributor Author

  • Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.

鈽濓笍?

I haven't done it against beta, as this is more a security fix than a new feature (thus better suited for master than for beta).

And are the License issues with the parser resolved? A long time ago the author suddenly changed the license to be something proprietary, that made me pick the last version with the MIT license and never update.

Should be resolved with this change to the license: NaturalIntelligence/fast-xml-parser@1357c5d

After this PR, if you change it to the beta branch, I鈥檒l create a new none beta release with all the changes and this change.

Okay, I'll change the base branch later today.

@theimo1221
Copy link
Contributor Author

See #181

@theimo1221 theimo1221 closed this Jun 11, 2023
@theimo1221 theimo1221 deleted the update-fast-xml branch June 11, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants