Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicConsumer does not support FanOutConfig, only PollingConfig #59

Closed
googley42 opened this issue Mar 30, 2020 · 1 comment
Closed

DynamicConsumer does not support FanOutConfig, only PollingConfig #59

googley42 opened this issue Mar 30, 2020 · 1 comment

Comments

@googley42
Copy link
Collaborator

googley42 commented Mar 30, 2020 •
edited

I noticed that the DynamicConsumer does not support FanOutConfig, only PollingConfig - see https://github.com/svroonland/zio-kinesis/blob/master/src/main/scala/nl/vroste/zio/kinesis/client/DynamicConsumer.scala#L159 .

I will have a go at creating a PR
googley42 added a commit to googley42/zio-kinesis that referenced this issue Mar 31, 2020
@googley42
svroonland#59 - support for enhanced fan out
22816f4
googley42 added a commit to googley42/zio-kinesis that referenced this issue Apr 3, 2020
@googley42
svroonland#59 - isEnhancedFanOut now defaults to true and documente…
080432b 
…d this flag.
svroonland pushed a commit that referenced this issue Apr 3, 2020
@googley42
#59 - support for enhanced fan out (#60)
457fbe3 
* #59 - support for enhanced fan out

* #59 - `isEnhancedFanOut` now defaults to true and documented this flag.
@svroonland
Copy link
Owner

Implemented in #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svroonland @googley42